-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ISSUE_TEMPLATE.md #35
Conversation
ISSUE_TEMPLATE.md
Outdated
|
||
### Label | ||
|
||
[Choose the label that best fits the issue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give a list of labels here to choose from. These labels should match the GITHUB labels for issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least give a URL of where to find the labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hjmjohnson thanks for the review ! This was just a proposal; the question is whether we will effectively be using labels. The VTK folks do have some, and they do use them frequently. If for any reason it is decided that we will not be using labels (despite I'd be for proposing/using them), then adding such a section is not worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add the Label and Milestones section later once we have figured out what labels to use and sorted out the milestoning system.
ISSUE_TEMPLATE.md
Outdated
|
||
### Label | ||
|
||
[Choose the label that best fits the issue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least give a URL of where to find the labels.
ISSUE_TEMPLATE.md
Outdated
|
||
[Choose the label that best fits the issue] | ||
|
||
### Milestones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give a URL of where to find the list of Milestones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as for the labels.
An additional comment as for checking the ITK version: we could run Any thoughts or improvements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, Jon!
ISSUE_TEMPLATE.md
Outdated
@@ -0,0 +1,46 @@ | |||
[Before submitting an issue, please check that your isssue hasn't been already filed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isssue -> issue
ISSUE_TEMPLATE.md
Outdated
|
||
### Label | ||
|
||
[Choose the label that best fits the issue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add the Label and Milestones section later once we have figured out what labels to use and sorted out the milestoning system.
Done. Commit 7970cf0 removes the I also changed the section name I also added a note at the bottom to invite users to ask questions in discourse. If you think it requires rewording, let me know. If you think the style of the comments should be changed (e.g. italics instead of or in addition to square brackets), let me know. |
Create an `ISSUE_TEMPLATE.md` file to provide a guide when submitting issues to ITK. Change-Id: I0828b37f5999fe1d2acb59885c0ba1dc648b5d67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great. Thanks @jhlegarreta !
We still need to merge via Gerrit / Git staging system for now given how the repository mirroring is setup.
|
||
[Any additional information, configuration or data that might be necessary to reproduce the issue.] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isses -> issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@thewtex Thanks ! I've submitted a topic to gerrit: to further review/merge this. I'm closing this PR then. |
Create an
ISSUE_TEMPLATE.md
file to provide a guide when submitting issues to ITK.