-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Fix Regitration::FEM
module PrintSelf
compiler errors
#3918
COMP: Fix Regitration::FEM
module PrintSelf
compiler errors
#3918
Conversation
Fix miscellaneous compiler errors in `Registration::FEM` module classes' `PrintSelf` methods. Fixes: ``` ITK\Modules\Registration\FEM\include\itkFEMFiniteDifferenceFunctionLoad.hxx(358,3): error C2440: 'static_cast': cannot convert from 'const itk::fem::Solution::ConstPointer' to 'const itk::LightObject *' ``` ``` ITK\Modules\Registration\FEM\include\itkFEMFiniteDifferenceFunctionLoad.hxx(358,3): error C2039: 'Print': is not a member of 'itk::fem::Solution' ``` and ``` ITK\Modules\Numerics\FEM\include\itkImageToRectilinearFEMObjectFilter.hxx(302,22): error C2275: 'itk::fem::Material': expected an expression instead of a type ``` ``` ITK\Modules\Numerics\FEM\include\itkImageToRectilinearFEMObjectFilter.hxx(302,3): error C3861: 'itkPrintSelfObject': identifier not found ``` and ``` ITK\Modules\Registration\FEM\include\itkFEMRegistrationFilter.hxx(1471,9): error C2440: 'static_cast': cannot convert from 'const unsigned int' to 'itk::Size<3>' ``` ``` ITK\Modules\Registration\FEM\include\itkFEMRegistrationFilter.hxx(1529,16): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'const itk::fem::FEMRegistrationFilter<InputImageType,InputImageType,FEMObjectType>::LandmarkArrayType' (or there is no acceptable conversion) ``` raised for example in: https://open.cdash.org/viewBuildError.php?buildid=8462352 Inadvertently introduced in c47ed1c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jhlegarreta! 💚
These look like new errors: https://open.cdash.org/viewBuildError.php?buildid=8473470. |
Will have a look tonight. The build was passing locally for me on a Win machine with the module at issue enabled. We might want to set up an Azure build with all non-default modules enabled to avoid as much as possible such issues. |
Had a look at them. They are the same as those pointed bi Mikhail in #3872 (comment). They were addressed as followed in #3872 (comment). Not sure why the have been reported to the dashboard. e.g. the error:
points to this line: which only contains a string that is being serialized to the ostream. |
I just realized that when |
My local set up does not allow me to test that as I do not have OpenCL installed/CMake does not install it when enabling the GPU flag, so if you can set up a machine that enables the flag, I would be able to try to address them. Thanks. |
Did you give https://github.com/KhronosGroup/OpenCL-SDK/releases a try? |
Here is the log from building on my machine: |
So PR #3928:
|
I assume that lack of |
Fix miscellaneous compiler errors in
Registration::FEM
module classes'PrintSelf
methods.Fixes:
and
and
raised for example in:
https://open.cdash.org/viewBuildError.php?buildid=8462352
Inadvertently introduced in c47ed1c.
PR Checklist