-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Fix implicit copy constructor definition deprecation warnings #4639
COMP: Fix implicit copy constructor definition deprecation warnings #4639
Conversation
Re #4626 (comment) and #4627 (comment): 199 new warnings appeared today on RogueResearch22. Maybe the compiler does not show more than that many warnings. This addresses a few of them. |
Edit: Solved in PR #4640. Thanks Matt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚
2e90b44
to
d512c77
Compare
Fix implicit copy constructor definition deprecation warnings in image/mesh file reader exception classes by using explicitly the compiler-provided default implementation (together with the assignment assignment and move semantics). Fixes: ``` [CTest: warning matched] /Users/builder/externalModules/IO/ImageBase/include/itkImageFileReaderException.h:54:3: warning: definition of implicit copy constructor for 'ImageFileReaderException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~ImageFileReaderException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/ImageBase/include/itkImageFileWriter.h:57:3: warning: definition of implicit copy constructor for 'ImageFileWriterException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~ImageFileWriterException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/MeshBase/include/itkMeshFileReaderException.h:36:3: warning: definition of implicit copy constructor for 'MeshFileReaderException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~MeshFileReaderException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/MeshBase/include/itkMeshFileWriterException.h:36:3: warning: definition of implicit copy constructor for 'MeshFileWriterException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~MeshFileWriterException() noexcept override; ^ ``` Raised for example in: https://open.cdash.org/viewBuildError.php?type=1&buildid=9587875
d512c77
to
d1ebdfa
Compare
Tried to use the copy and move disallow macro first, but the compiler was complaining: Rather that trying with the defaults only for the image file reader/writer exceptions only (or the constructor vs assignment only), decided to be consistent across all 4. Maybe some more investigation on which can be deleted vs defaulted, and developing a macro would be useful in a separate PR. I don't have the bandwidth for that, unfortunately. |
Failures on macOS arm64 are unrelated: |
Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
Instead of "manually" defaulting their copy and move member functions. Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
Instead of "manually" defaulting their copy and move member functions. Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
Fix implicit copy constructor definition deprecation warnings in image/mesh file reader exception classes by using explicitly the compiler-provided default implementation (together with the assignment
assignment and move semantics).
Fixes:
and
and
and
Raised for example in:
https://open.cdash.org/viewBuildError.php?type=1&buildid=9587875
PR Checklist