COMP: Fix implicit copy constructor definition deprecation warnings #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Compiler
|
Re #4626 (comment) and #4627 (comment): 199 new warnings appeared today on RogueResearch22. Maybe the compiler does not show more than that many warnings. This addresses a few of them. |
|
Edit: Solved in PR #4640. Thanks Matt. |
jhlegarreta
force-pushed
the
FixImplicitCopyWarningsReadWriteExc
branch
3 times, most recently
from
2e90b44
to
d512c77
Compare
Fix implicit copy constructor definition deprecation warnings in image/mesh file reader exception classes by using explicitly the compiler-provided default implementation (together with the assignment assignment and move semantics). Fixes: ``` [CTest: warning matched] /Users/builder/externalModules/IO/ImageBase/include/itkImageFileReaderException.h:54:3: warning: definition of implicit copy constructor for 'ImageFileReaderException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~ImageFileReaderException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/ImageBase/include/itkImageFileWriter.h:57:3: warning: definition of implicit copy constructor for 'ImageFileWriterException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~ImageFileWriterException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/MeshBase/include/itkMeshFileReaderException.h:36:3: warning: definition of implicit copy constructor for 'MeshFileReaderException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~MeshFileReaderException() noexcept override; ^ ``` and ``` [CTest: warning matched] /Users/builder/externalModules/IO/MeshBase/include/itkMeshFileWriterException.h:36:3: warning: definition of implicit copy constructor for 'MeshFileWriterException' is deprecated because it has a user-declared destructor [-Wdeprecated] ~MeshFileWriterException() noexcept override; ^ ``` Raised for example in: https://open.cdash.org/viewBuildError.php?type=1&buildid=9587875
jhlegarreta
force-pushed
the
FixImplicitCopyWarningsReadWriteExc
branch
from
d512c77
to
d1ebdfa
Compare
|
Tried to use the copy and move disallow macro first, but the compiler was complaining: Rather that trying with the defaults only for the image file reader/writer exceptions only (or the constructor vs assignment only), decided to be consistent across all 4. Maybe some more investigation on which can be deleted vs defaulted, and developing a macro would be useful in a separate PR. I don't have the bandwidth for that, unfortunately. |
|
Failures on macOS arm64 are unrelated: |
thewtex
approved these changes
May 3, 2024
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
May 8, 2024
Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
May 8, 2024
Instead of "manually" defaulting their copy and move member functions. Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
May 13, 2024
Instead of "manually" defaulting their copy and move member functions. Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implicit copy constructor definition deprecation warnings in image/mesh file reader exception classes by using explicitly the compiler-provided default implementation (together with the assignment
assignment and move semantics).
Fixes:
and
and
and
Raised for example in:
https://open.cdash.org/viewBuildError.php?type=1&buildid=9587875
PR Checklist