-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add indent to image's matrix printing #4772
ENH: Add indent to image's matrix printing #4772
Conversation
This was the print out style that Copilot made up. I am not sure if a numpy style with New printout from Image:
Old print out:
And a numpy identity matrix:
|
I like it this way. I thought about whether to ask for before/after output 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the choice, maybe because I got used to it, I like Numpy's better (with the appropriate indentation, but I am fine with the current style improvement.
Note: the matrix in AffineTransform is printed correctly with in a CompositeTransform. The Transform classes should be consistent. |
64b4af7
to
8e197de
Compare
Add Matrix::PrintSelf method which uses ITK's indent object to allow proper indenting of nested objects. Add indenting to image's matrix printing. Fixes left aligned matrix values when printing the Image classes.
8e197de
to
8624df0
Compare
/azp run ITK.Linux.Python |
Is this ready to merge? Remove draft status? |
Let see if @thewtex has a comment about the preferred formatting of the output for the Matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks like a good improvement to me. @blowekamp thanks for taking the time to make the tweak.
@blowekamp time to merge? |
Add Matrix::PrintSelf method which uses ITK's indent object to allow proper indenting of nested objects.
Fixes left aligned matrix values when printing the Image classes.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.