Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Add ITKMontage's PhaseCorrelationOptimizer to API ignore list #4774

Merged
merged 1 commit into from
Jul 15, 2024
Merged

COMP: Add ITKMontage's PhaseCorrelationOptimizer to API ignore list #4774

merged 1 commit into from
Jul 15, 2024

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jul 11, 2024

Meant to address:

> python "M:/Dashboard/ITK/Wrapping/Generators/Python/Tests/verifyGetOutputAPIConsistency.py"
...
Traceback (most recent call last):
  File "M:\Dashboard\ITK\Wrapping\Generators\Python\Tests\verifyGetOutputAPIConsistency.py", line 104, in <module>
    tot, w = checkGetOutputConsistency(o, t)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "M:\Dashboard\ITK\Wrapping\Generators\Python\Tests\verifyGetOutputAPIConsistency.py", line 83, in checkGetOutputConsistency
    i.GetOutput()
TypeError: itkPhaseCorrelationOptimizerF2.GetOutput() missing 1 required positional argument: 'index' itkTestDriver: Process exited with return value: 1

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Jul 11, 2024
@dzenanz
COMP: Add ITKMontage's PhaseCorrelationOptimizer to API ignore list
9ff7a17 
Meant to address:

> python "M:/Dashboard/ITK/Wrapping/Generators/Python/Tests/verifyGetOutputAPIConsistency.py"
...
Traceback (most recent call last):
  File "M:\Dashboard\ITK\Wrapping\Generators\Python\Tests\verifyGetOutputAPIConsistency.py", line 104, in <module>
    tot, w = checkGetOutputConsistency(o, t)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "M:\Dashboard\ITK\Wrapping\Generators\Python\Tests\verifyGetOutputAPIConsistency.py", line 83, in checkGetOutputConsistency
    i.GetOutput()
TypeError: itkPhaseCorrelationOptimizerF2.GetOutput() missing 1 required positional argument: 'index'
itkTestDriver: Process exited with return value: 1
@dzenanz dzenanz merged commit f88a289 into InsightSoftwareConsortium:master Jul 15, 2024
13 checks passed
@dzenanz dzenanz deleted the apiConsistency branch July 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Python wrapping Python bindings for a class type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzenanz @thewtex @hjmjohnson