ENH: Provide GetSpacing/GetOrigin calls that wrap for python #4775
Conversation
github-actions
bot
added
type:Enhancement
| { | ||
| for (unsigned int i = 0; i < OutputImageDimension; ++i) | ||
| { | ||
| m_SpacingVector[i] = m_Spacing[i]; |
There was a problem hiding this comment.
If this assignment is done in the getter, what is the point of also having it as an ivar? This could be a local variable in the getter instead. Same remark for the other one.
There was a problem hiding this comment.
I was trying to avoid returning a reference to a local var and to make the minimal changes to the code to preserve backward compatibility. What do you recommend?
There was a problem hiding this comment.
Aha, so we can't return spacing by value? If so, this is fine.
There was a problem hiding this comment.
Yeah - this is still using a very old (the original) ITK API where spacing was double * - which doesn't wrap for python, hence this PR. For ITK v6.0, I'd like to do a major update to SpatialObjects to follow ITK's current API, but it will break backward compatibility.
Great point - will amend this commit! |
itk::SpatialObjectToImageFilter provided GetSpacing() and GetOrigin() calls that returned double * objects. That return type is not well supported by SWIG for python wrapping. Herein we provide GetSpacingVector() and GetOriginPoint() functions that return VectorType and PointType objects from the itk::Image class definition which are nicely wrapped by SWIG for python.
aylward
force-pushed
the
SOToImageFilterGetSpacing
branch
from
66fb443
to
b39f3f0
Compare
itk::SpatialObjectToImageFilter provided GetSpacing() and GetOrigin() calls that returned double * objects. That return type is not well supported by SWIG for python wrapping.
Herein we provide GetSpacingVector() and GetOriginPoint() functions that return VectorType and PointType objects from the itk::Image class definition which are nicely wrapped by SWIG for python.
See: https://discourse.itk.org/t/image-spacing-value-interactions-in-itk-python-wrapping/6707