BUG: Remove SpatialObjectProperty's writable string methods from SWIG #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Bug
|
Seems to work: |
aylward
approved these changes
Sep 9, 2024
blowekamp
commented
Sep 11, 2024
| @@ -123,15 +125,13 @@ class ITKSpatialObjects_EXPORT SpatialObjectProperty | |||
| return value; | |||
| } | |||
|
|
|||
|
|
|||
| #if !defined(SWIG) && !defined(ITK_WRAPPING_PARSER) | |||
There was a problem hiding this comment.
I think this should only be dependent on ITK_WRAPPING_PARSER
SWIG's binding for writable std::string objects is a "std::string *" which is not implemented.
blowekamp
force-pushed
the
fix_spatial_object_property_string
branch
from
f9e557e
to
80be78b
Compare
|
@blowekamp thanks for following up with a patch on this!
Yes, done! efe773f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIG's binding for writable std::string objects is a "std::string *" which is not implemented.
closes #4779
replaces #4776
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.