PERF: improve DCMTKFileReader::CanReadFile perf #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using DcmMetaInfo avoids loading full dataset into memory, which can be very expensive for large files. For example, in Slicer, DCMTK is one of the first ITK readers tested. Without this change, attempting to read a multi-gigabyte NIfTI file will hang for many minutes in the ::CanReadFile code path. With this change, the test path completes in under 50ms.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@ihnorton an invite was sent to the Since we have not finalized the transition to GitHub, I will push this to Gerrit and merge there. |
|
Pushed here: |
|
Thanks. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using DcmMetaInfo avoids loading full dataset into memory, which
can be very expensive for large files.
For example, in Slicer, DCMTK is one of the first ITK readers tested.
Without this change, attempting to read a multi-gigabyte NIfTI file
will hang for many minutes in the ::CanReadFile code path. With this
change, the test path completes in under 50ms.