STYLE: Deprecated FixedArray member functions rBegin() and rEnd() #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
approved these changes
May 10, 2019
dzenanz
approved these changes
May 10, 2019
|
Force-pushed, just to fix the deprecation warnings in itkFixedArrayTest.cxx, to preserve the unit test added by @maekclena even when legacy is removed (ITK_LEGACY_REMOVE), and to clarify the documentation + commit message. |
Declared `FixedArray` member functions `rBegin()` and `rEnd()` legacy-only, as they are superseded by `rbegin()` and `rend()'. The new reverse iterators can be passed directly to an `std` algorithm, e.g., `std::sort(fixedArray.rbegin(), fixedArray.rend())`. Unlike the old reverse iterators, the new ones support random access iteration. Deprecation suggested by @dzenanz while discussing pull request #850
maekclena
approved these changes
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared
FixedArraymember functionsrBegin()andrEnd()legacy-only, as they are superseded by
rbegin()and `rend()'.The new reverse iterators can be passed directly to an
stdalgorithm,e.g.,
std::sort(fixedArray.rbegin(), fixedArray.rend()). Unlike theold reverse iterators, the new ones support random access iteration.
Deprecation suggested by @dzenanz while discussing pull request #850