-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Use and move ITK_DISALLOW_COPY_AND_ASSIGN calls to public section. #9
Merged
thewtex
merged 1 commit into
InsightSoftwareConsortium:master
from
jhlegarreta:UseDisallowCopyAndAssignMacro
Mar 19, 2019
Merged
COMP: Use and move ITK_DISALLOW_COPY_AND_ASSIGN calls to public section. #9
thewtex
merged 1 commit into
InsightSoftwareConsortium:master
from
jhlegarreta:UseDisallowCopyAndAssignMacro
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
from
March 17, 2019 20:12
4ce51fa
to
77d7f2a
Compare
77d7f2a rebased on master. |
dzenanz
approved these changes
Mar 18, 2019
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
from
March 18, 2019 22:52
77d7f2a
to
68cd0e3
Compare
77d7f2a rebased on master. |
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
from
March 19, 2019 00:02
68cd0e3
to
f002660
Compare
@thewtex any guess? |
|
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
from
March 19, 2019 01:33
f002660
to
fcf9e06
Compare
:-S Need some vacation I guess. Thanks Matt. |
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
3 times, most recently
from
March 19, 2019 01:40
82e025d
to
596de57
Compare
Use the `ITK_DISALLOW_COPY_AND_ASSIGN` macro to enhance consistency across the the toolkit when disallowing the copy constructor and the assign operator. Move the `ITK_DISALLOW_COPY_AND_ASSIGN` calls to public section following the discussion in https://discourse.itk.org/t/itk-disallow-copy-and-assign/648
jhlegarreta
force-pushed
the
UseDisallowCopyAndAssignMacro
branch
from
March 19, 2019 01:41
596de57
to
3f947da
Compare
thewtex
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks are necessary, too! 🍹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
ITK_DISALLOW_COPY_AND_ASSIGN
macro to enhance consistency acrossthe the toolkit when disallowing the copy constructor and the assign
operator.
Move the
ITK_DISALLOW_COPY_AND_ASSIGN
calls to public section followingthe discussion in
https://discourse.itk.org/t/itk-disallow-copy-and-assign/648