Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Use and move ITK_DISALLOW_COPY_AND_ASSIGN calls to public section. #9

Conversation

jhlegarreta
Copy link
Member

Use the ITK_DISALLOW_COPY_AND_ASSIGN macro to enhance consistency across
the the toolkit when disallowing the copy constructor and the assign
operator.

Move the ITK_DISALLOW_COPY_AND_ASSIGN calls to public section following
the discussion in
https://discourse.itk.org/t/itk-disallow-copy-and-assign/648

@jhlegarreta
Copy link
Member Author

77d7f2a rebased on master.

@jhlegarreta jhlegarreta force-pushed the UseDisallowCopyAndAssignMacro branch from 77d7f2a to 68cd0e3 Compare March 18, 2019 22:52
@jhlegarreta
Copy link
Member Author

77d7f2a rebased on master.

@jhlegarreta jhlegarreta force-pushed the UseDisallowCopyAndAssignMacro branch from 68cd0e3 to f002660 Compare March 19, 2019 00:02
@jhlegarreta
Copy link
Member Author

d:\a\1\s\include\itkTimeVaryingVelocityFieldSemiLagrangianTransform.h(39): warning C4183:
 'DISALLOW_COPY_AND_ASSIGN': missing return type; assumed to be a member function returning 'int'

@thewtex any guess?

@thewtex
Copy link
Member

thewtex commented Mar 19, 2019

DISALLOW_COPY_AND_ASSIGN -> ITK_DISALLOW_COPY_AND_ASSIGN

@jhlegarreta jhlegarreta force-pushed the UseDisallowCopyAndAssignMacro branch from f002660 to fcf9e06 Compare March 19, 2019 01:33
@jhlegarreta
Copy link
Member Author

:-S Need some vacation I guess. Thanks Matt.

@jhlegarreta jhlegarreta force-pushed the UseDisallowCopyAndAssignMacro branch 3 times, most recently from 82e025d to 596de57 Compare March 19, 2019 01:40
Use the `ITK_DISALLOW_COPY_AND_ASSIGN` macro to enhance consistency across
the the toolkit when disallowing the copy constructor and the assign
operator.

Move the `ITK_DISALLOW_COPY_AND_ASSIGN` calls to public section following
the discussion in
https://discourse.itk.org/t/itk-disallow-copy-and-assign/648
@jhlegarreta jhlegarreta force-pushed the UseDisallowCopyAndAssignMacro branch from 596de57 to 3f947da Compare March 19, 2019 01:41
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks are necessary, too! 🍹

@thewtex thewtex merged commit 9e24ac7 into InsightSoftwareConsortium:master Mar 19, 2019
@jhlegarreta jhlegarreta deleted the UseDisallowCopyAndAssignMacro branch March 19, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants