Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Transition project configuration to pyproject.toml #10

Merged

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Jun 25, 2024

  • ENH: Transition project configuration to pyproject.toml
  • COMP: Update CI configuration for ITK 5.4
  • COMP: Fix missing s in header license notice URL http link

Transition project configuration to `pyproject.toml`.

Used the `setup-py-to-pyproject-toml.py` script in the
`ITKModuleTemplate` repository:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

as a starting base, then made manual changes as necessary.
@thewtex
Copy link
Member

thewtex commented Jun 25, 2024

👍

Could we update the CI config to the remote module action?

Update CI configuration for ITK 5.4.
@jhlegarreta
Copy link
Member Author

Could we update the CI config to the remote module action?

Done.

Fix missing `s` in header license notice URL http link.

Fixes:
```
ITKRingArtifact/include/itkFourierStripeArtifactImageFilter.h:9:
 error: Header mismatch:
 ://www.apache.org/licenses/LICENSE-2.0.txt
 (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
ITKRingArtifact/include/itkFourierStripeArtifactImageFilter.hxx:9:
 error: Header mismatch:
 ://www.apache.org/licenses/LICENSE-2.0.txt
 (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
ITKRingArtifact/test/itkFourierStripeArtifactImageFilterTest.cxx:9:
 error: Header mismatch:
 ://www.apache.org/licenses/LICENSE-2.0.txt
 (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
```

raised for example at:
https://github.com/InsightSoftwareConsortium/ITKRingArtifact/actions/runs/9662460884/job/26652393725#step:14:60
and
https://github.com/InsightSoftwareConsortium/ITKRingArtifact/actions/runs/9663108489/job/26654482751?pr=10#step:14:60
@thewtex
Copy link
Member

thewtex commented Jun 25, 2024

💚 @jhlegarreta thanks!

I will bump the version and switch the default branch via the web ui.

@thewtex thewtex merged commit 309cb94 into InsightSoftwareConsortium:master Jun 25, 2024
31 checks passed
@jhlegarreta jhlegarreta deleted the TransitionToPyprojectToml branch June 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants