Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Added ReadAnImage Python script #290

Merged
merged 1 commit into from
Jun 7, 2021
Merged

ENH: Added ReadAnImage Python script #290

merged 1 commit into from
Jun 7, 2021

Conversation

kian-weimer
Copy link
Contributor

Created a Python ReadAnImage example based off of the existing C++ example.

@kian-weimer
Copy link
Contributor Author

kian-weimer commented May 28, 2021 •
edited
Loading

For the future, would it be preferable to have multiple examples in one PR?

dzenanz
dzenanz approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with one PR per example. Others might have a different preference, but it does not matter much. If you do that, please have each new example in a commit of its own.

@dzenanz
Copy link
Member

dzenanz commented Jun 2, 2021

Could you rebase on master? The log should be shorter then.

@kian-weimer
Copy link
Contributor Author

Rebased. Thanks for the tip. I'm not sure what the issue is yet.

thewtex
thewtex previously requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy the license header from another Python example.

src/IO/ImageBase/ReadAnImage/Code.py Show resolved Hide resolved
@thewtex thewtex requested a review from hjmjohnson June 3, 2021 01:23
@dzenanz dzenanz requested a review from thewtex June 3, 2021 21:40
@dzenanz dzenanz dismissed thewtex’s stale review June 7, 2021 17:39

Changes applied

@dzenanz dzenanz merged commit 35ca99d into InsightSoftwareConsortium:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kian-weimer @dzenanz @thewtex