Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Use itk::ReadImage and itk::WriteImage in src/Core examples #303

Merged
merged 1 commit into from
Jul 7, 2021
Merged

STYLE: Use itk::ReadImage and itk::WriteImage in src/Core examples #303

merged 1 commit into from
Jul 7, 2021

Conversation

josetascon
Copy link
Contributor

@josetascon josetascon commented Jul 6, 2021 •
edited by dzenanz
Loading

Ref #226.

@josetascon josetascon mentioned this pull request Jul 6, 2021
Closed
dzenanz
dzenanz reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Minor remarks in-line.

src/Core/Common/AddNoiseToBinaryImage/Code.cxx Outdated Show resolved Hide resolved
src/Core/Common/FindMaxAndMinInImage/Code.cxx Outdated Show resolved Hide resolved
src/Core/Common/ImageRegionOverlap/Code.cxx Outdated Show resolved Hide resolved
src/Core/ImageFunction/ResampleSegmentedImage/Code.cxx Outdated Show resolved Hide resolved
src/Core/ImageFunction/ResampleSegmentedImage/Code.cxx Outdated Show resolved Hide resolved
src/Core/SpatialObjects/ConvertSpatialObjectToImage/Code.cxx Outdated Show resolved Hide resolved
@dzenanz
Copy link
Member

dzenanz commented Jul 6, 2021 •
edited
Loading

Also, you should use clang-format to apply ITK's style. See discrepancies linter points out:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/pull/303/checks?check_run_id=3000997260

@josetascon josetascon force-pushed the readimage-writeimage branch 4 times, most recently from bec7f2d to 9e4d5eb Compare July 7, 2021 06:26
@josetascon
Copy link
Contributor Author

Also, you should use clang-format to apply ITK's style. See discrepancies linter points out:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/pull/303/checks?check_run_id=3000997260

Fixed.

@josetascon
Copy link
Contributor Author

@dzenanz, I have resolved your comments and deleted unnecessary file reader and writer imports.

dzenanz
dzenanz approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dzenanz dzenanz merged commit 9ab3696 into InsightSoftwareConsortium:master Jul 7, 2021
@josetascon josetascon deleted the readimage-writeimage branch July 8, 2021 07:35
@dzenanz dzenanz mentioned this pull request Jul 8, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josetascon @dzenanz