Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Initialize image buffer in Inverse FFT example #312

Merged
merged 1 commit into from
Nov 29, 2021
Merged

BUG: Initialize image buffer in Inverse FFT example #312

merged 1 commit into from
Nov 29, 2021

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Nov 29, 2021

Previous behavior: FFT and baseline comparison sometimes returns NAN pixel values due to uninitialized buffer

Updated behavior: Pixels are initialized to 0; FFT and baseline comparison succeed

@tbirdso tbirdso requested a review from thewtex November 29, 2021 18:19
@github-actions github-actions bot added area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances labels Nov 29, 2021
@tbirdso tbirdso mentioned this pull request Nov 29, 2021
Merged
5 tasks
dzenanz
dzenanz approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #308.

@tbirdso
Copy link
Contributor Author

tbirdso commented Nov 29, 2021

Docs failure seems unrelated to this change: https://open.cdash.org/viewBuildError.php?type=1&buildid=7597891

WARNING: while setting up extension sphinx.addnodes: node class 'meta' is already registered, its visitors will be overridden

@dzenanz dzenanz merged commit ff614cb into InsightSoftwareConsortium:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbirdso @dzenanz