remove recursive header includes #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to include either .h or .hxx files as header files required recursively reading the .h files twice. The added complexity is unnecessary, costly, and can confuse static analysis tools that monitor header guardes (due to reaching the maximum depth of recursion limits for nested #ifdefs in checking).
github-actions
bot
added
area:Core
dzenanz
approved these changes
Dec 17, 2021
| @@ -1,7 +1,6 @@ | |||
| #ifndef __itkImageFilter_hxx | |||
| #define __itkImageFilter_hxx | |||
|
|
|||
| #include "ImageFilter.h" | |||
There was a problem hiding this comment.
Is a similar change needed in the software guide? If there are any instances of this, it is.
There was a problem hiding this comment.
InsightSoftwareConsortium/ITKSoftwareGuide#171 for the coding style guidelines section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMP: Remove inclusion of .hxx files as headers
The ability to include either .h or .hxx files as
header files required recursively reading the
.h files twice. The added complexity is
unnecessary, costly, and can confuse static
analysis tools that monitor header guardes (due
to reaching the maximum depth of recursion
limits for nested #ifdefs in checking).