Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Catch exceptions by _const_ reference #361

Merged
merged 1 commit into from
May 16, 2022
Merged

STYLE: Catch exceptions by _const_ reference #361

merged 1 commit into from
May 16, 2022

Conversation

N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented May 16, 2022 •
edited
Loading

Replaced catch \((\S+) & & with catch \(const $1 &, using Notepad++ v8.3.3,
Find in Files, Search Mode: Regular expression.

Follow-up to ITK pull request InsightSoftwareConsortium/ITK#3419
commit InsightSoftwareConsortium/ITK@f222a5e
(merged on May 11, 2022)

Triggered by the discussion starting at InsightSoftwareConsortium/ITK#3339 (comment)

@N-Dekker
STYLE: Catch exceptions by _const_ reference
851d543 
Replaced `catch \((\S+) &` & with `catch \(const $1 &`, using Notepad++ v8.3.3,
Find in Files, Search Mode: Regular expression.

Follow-up to ITK pull request InsightSoftwareConsortium/ITK#3419
commit InsightSoftwareConsortium/ITK@f222a5e
(merged on May 11, 2022)
@github-actions github-actions bot added area:Bridge Issues affecting the Bridge module area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Nonunit Issues affecting the Nonunit module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module language:C++ Changes to C++ examples type:Style Style changes: no logic impact (indentation, comments, naming) labels May 16, 2022
@N-Dekker N-Dekker marked this pull request as ready for review May 16, 2022 12:31
@N-Dekker
Copy link
Collaborator Author

@tbirdso Hi Tom! Can you please have a look at my very first ITKSphinxExamples pull request ? 😃

tbirdso
tbirdso reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @N-Dekker ! The changes look good. There are a few docs CDash warnings that I am not sure are related to this PR, I will re-run CI to compare.

tbirdso
tbirdso approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that docs build failures are already present in master branch CI (see CI results) and are independent of these changes.

@tbirdso tbirdso merged commit 1bffa54 into InsightSoftwareConsortium:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

Assignees
No one assigned
Labels
area:Bridge Issues affecting the Bridge module area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Nonunit Issues affecting the Nonunit module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module language:C++ Changes to C++ examples type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-Dekker @tbirdso