Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Switch Github Actions Linux environment #393

Merged

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Aug 17, 2022

Switch Github Actions Linux environment version to ubuntu-20.04.

ubuntu-18.04 is being deprecated and support will end by 12/1/2022:
actions/runner-images#6002

Related to recent warnings in the Azure Pipelines Linux environment
being used in the main ITK repository:
InsightSoftwareConsortium/ITK@497c3a7

Switch Github Actions Linux environment version to `ubuntu-20.04`.

`ubuntu-18.04` is being deprecated and support will end by 12/1/2022:
actions/runner-images#6002

Related to recent warnings in the Azure Pipelines Linux environment
being used in the main ITK repository:
InsightSoftwareConsortium/ITK@497c3a7
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Aug 17, 2022
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta !

@thewtex thewtex merged commit b731d62 into InsightSoftwareConsortium:master Aug 17, 2022
@jhlegarreta jhlegarreta deleted the UpdateLinuxGHAVersion branch August 17, 2022 18:39
@jhlegarreta
Copy link
Member Author

Build failures after merging this PR are unrelated to this patch set:
https://open.cdash.org/viewBuildError.php?buildid=8104830

There seems to be an issue with this file:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilter.png.sha512

Failures were being reported lately.

@hjmjohnson Does this ring a bell?

@hjmjohnson
Copy link
Member

@jhlegarreta This does not ring any bells for me. It seems that there is a missing file. Perhaps that file was on one of the now deprecated source locations.

Hopefully someone has that file in their local cache and can upload it to midas.

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Aug 18, 2022

@jhlegarreta This does not ring any bells for me. It seems that there is a missing file. Perhaps that file was on one of the now deprecated source locations.

Hopefully someone has that file in their local cache and can upload it to midas.

OK. Was asking because according to GitHub you did the first commit of the file. But it was a while ago, so not sure why the issue appeared only recently. Maybe there is a clash with some other filename (?).

@hjmjohnson
Copy link
Member

@jhlegarreta This file appears to be on data.kitware.com site at:

https://data.kitware.com/#item/5e5071daaf2e2eed35c6449a

I don't know why it is not found and downloaded.

@dzenanz
Copy link
Member

dzenanz commented Aug 18, 2022

Maybe examples repo uses a cached version of external data? And this file was added recently?

@jhlegarreta
Copy link
Member Author

And this file was added recently?

The file seems to have been added in 2019 :-S.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants