Fix python3 find package #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Bridge
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
06edc67 to
035576e
Compare
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
035576e to
37fdc68
Compare
|
@dzenanz Thanks for the comment. I made this change, and also will be forcing ITK to 3.7 or greater soon. |
dzenanz
approved these changes
Aug 19, 2022
|
🎉 Published on https://examples.itk.org as production |
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
37fdc68 to
e79ccd9
Compare
|
@hjmjohnson could this please be rebased on |
The CI workflow already uses 3.9, and Python 3.7 is 5 months from deprecation, so if a minimum version needs to be enforced, maybe it should be 3.8. At the same time:
|
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
e79ccd9 to
22a225c
Compare
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
22a225c to
9bef98e
Compare
|
FYI: ccmake -GNinja -B ~/Dashboard/src/SphinxExamples-bld -S ~/Dashboard/src/ITK/Modules/Remote/SphinxExamples;
cd ~/Dashboard/src/SphinxExamples-bld && ninjaThis builds successfully. |
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
2 times, most recently
from
e40bf6e to
0ac20c0
Compare
|
This is also working: ccmake "-DCMAKE_BUILD_TYPE:STRING=Release" "-GNinja" -B SphinxExamples-bld -S ~/Dashboard/src/ITK/Modules/Remote/SphinxExamples/Superbuild
cd SphinxExamples-bld
ninja |
Now that cmake FindPython3 can be universally used, prefer to only use that set of variable names for identifying the python executables. Intial procesing with manual cleanup by: ITK/Utilities/Maintenance/FindPython3_ModernizeCMake.sh Finding the correct python version should always respect the Python3_ROOT_DIR variable provided during building.
hjmjohnson
force-pushed
the
fix-python3-find_package
branch
from
0ac20c0 to
54c4d29
Compare
|
This works locally, but the GitHub actions are all broken for all PRS. |
dzenanz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to remove deprecated find_package(PythonLib) and find_package(PythonInterp) and the associated variables.
Use find_package(Python3) and its associated variables.