ENH: Update CMake to decouple archives from example builds #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Bridge
dzenanz
approved these changes
Nov 10, 2022
|
Seeing repeated failures due to SHA256 resource download failures, which are in the process of being addressed with #398. https://open.cdash.org/viewBuildError.php?buildid=8270992 Documentation builds on my Ubuntu machine and I have verified that archives are generated based on folder structure to address #373. @thewtex Would you prefer that I wait and rebase once #398 is stable or go ahead and merge? |
Addresses issue where archives were not build for examples without an `add_example()` call, resulting in broken download links on `examples.itk.org`. New behavior packages example archives for all examples to accompany Sphinx documentation. Also cleans up `CMakeLists.txt` for several module groups.
tbirdso
force-pushed
the
update-archive-script
branch
from
b6cd49b
to
2394e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue where archives were not build for examples without an
add_example()call, resulting in broken download links onexamples.itk.org.New behavior packages example archives for all examples to accompany Sphinx documentation. Also cleans up
CMakeLists.txtfor several module groups.Closes #373.