Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Itk 5.3.0 #402

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Itk 5.3.0 #402

merged 6 commits into from
Dec 7, 2022

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Nov 29, 2022

No description provided.

@thewtex thewtex marked this pull request as ready for review November 29, 2022 22:16
@thewtex thewtex force-pushed the itk-5.3.0 branch 2 times, most recently from 07e24ea to 76a97b0 Compare November 29, 2022 22:22
dzenanz
dzenanz approved these changes Nov 29, 2022
View reviewed changes
.github/workflows/build-test-publish.yml Outdated Show resolved Hide resolved
@thewtex
ENH: Bump ITK version to 5.3.0
4078f3f 
- find_package
- Superbuild Git Tag
- Superbuild Python package
- CI version
- Bump CMake policy versions to match ITK 5.3.0

- Testing data root CID (one new testing file)
- Add estuary.tech gateway
- Add GitHub Pages testing data resource
@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Nov 30, 2022
@thewtex
Copy link
Member Author

thewtex commented Nov 30, 2022

@dzenanz why is there a Windows warning:

D:\a\bld\ITK\Modules\ThirdParty\ZLIB\src\itkzlib-ng\crc32_braid.c(128): warning C4311: 'type cast': pointer truncation from 'const uint8_t *' to 'unsigned long'

@dzenanz
Copy link
Member

dzenanz commented Nov 30, 2022

why is there a Windows warning

The examples are probably using some combination of options which we don't routinely test.

Found it: examples use a different version of zlib, not the one bundled with ITK.

dzenanz
dzenanz reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I was wrong, and external zlib wasn't the problem.

@dzenanz
Copy link
Member

dzenanz commented Dec 1, 2022

We rarely use/test ITK_LEGACY_SILENT option.

@dzenanz
Copy link
Member

dzenanz commented Dec 1, 2022

Maybe I was looking at the wrong build, and now the problem are 3 failing tests?

@dzenanz
Copy link
Member

dzenanz commented Dec 1, 2022

I issued a rerun of the failed jobs. With updated time, it will be easier to tell what is the problem.

@dzenanz
Copy link
Member

dzenanz commented Dec 1, 2022

The compile warnings are still there, D:\a\bld\ITK\Modules\ThirdParty\ZLIB\src\itkzlib-ng\crc32_braid.c(128): warning C4311: 'type cast': pointer truncation from 'const uint8_t *' to 'unsigned long' and /.../bld/ITKEx-build/src/Bridge/NumPy/ConvertNumPyArrayToitkImage/ConvertNumPyArrayToitkImage.ipynb:: WARNING: Pygments lexer name 'ipython3' is not known.

@dzenanz
Copy link
Member

dzenanz commented Dec 1, 2022

There is an outstanding PR to fix this in zlib-ng: zlib-ng/zlib-ng#1371. I still don't know why it doesn't show up on our nightly builds.

@thewtex thewtex force-pushed the itk-5.3.0 branch 2 times, most recently from 91fbf9e to 7ffc940 Compare December 5, 2022 03:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Python Notebook Changes to Python Notebook examples labels Dec 5, 2022
thewtex added a commit to thewtex/ITK that referenced this pull request Dec 5, 2022
@thewtex
COMP: zlib crc32_braid.c cast to smaller integer type
0cd5391 
Port of: zlib-ng/zlib-ng#1371

To address:

```
 D:\a\bld\ITK\Modules\ThirdParty\ZLIB\src\itkzlib-ng\crc32_braid.c(128): warning C4311: 'type cast': pointer truncation from 'const uint8_t *' to 'unsigned long'
```

in InsightSoftwareConsortium/ITKSphinxExamples#402
@thewtex thewtex mentioned this pull request Dec 5, 2022
Merged
@thewtex
BUG: Bump srvaroa/labeler to v0.9
57a8dea 
Hopefully address Docker build errors.
@thewtex
COMP: Remove Superbuild zlib
56fcffd 
Build warnings are preventing a clean dashboard, we no longer bulid
CPython, and we are reducing our dependency on VTK -- just use the
vendored version in ITK.
@thewtex
COMP: Enable IPython.sphinxext.ipython_console_highlighting
a428ef2 
To address:

```
ConvertNumPyArrayToitkImage.ipynb:: WARNING: Pygments lexer name 'ipython3' is not known
```

per:

- spatialaudio/nbsphinx#24

Also install ipywidgets for general use in the Superbuild.
@thewtex
COMP: Bump CI images to latest versions
c0c0fc3 
- windows-2022
- ubuntu-22.04
- macos-12

And other Action dependencies.
@thewtex thewtex force-pushed the itk-5.3.0 branch 2 times, most recently from e111ef6 to 8ad3832 Compare December 5, 2022 22:12
@thewtex
COMP: Address ITK Windows warnings
d68014a 
Bumps to HEAD of current ITK `release` branch to incorporate:

- InsightSoftwareConsortium/ITK@0892cd1
- InsightSoftwareConsortium/ITK@0cd5391

to address CI warnings.

We also need to enable ITK_LEGACY_REMOVE in the Superbuild.
@thewtex thewtex merged commit 438d11e into InsightSoftwareConsortium:master Dec 7, 2022
@thewtex thewtex deleted the itk-5.3.0 branch December 7, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Python Notebook Changes to Python Notebook examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewtex @dzenanz