Compiler and clang-tidy cleanups #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
hjmjohnson
force-pushed
the
sphinx-one-line-initialize
branch
from
85fa85a to
bb0ba2f
Compare
dzenanz
approved these changes
Nov 26, 2024
| p3[0] = 1.0; | ||
| p3[1] = 1.0; | ||
| p3[2] = 1.0; // third point ( 1, 1, 1 ) | ||
| const MeshType::PointType p0({ -1.0, -1.0, 0 }); // first point ( -1, -1, 0 ) |
There was a problem hiding this comment.
These comments are far less useful now.
Make the for loop variables match the comparison variable type.
hjmjohnson
force-pushed
the
sphinx-one-line-initialize
branch
from
bb0ba2f to
96ecbf1
Compare
Multiple declarations in a single statement reduces readability. Detect local variable declaration statements and update to have only one statement per declaration. Initialize values rather than independant assignments of each element
hjmjohnson
force-pushed
the
sphinx-one-line-initialize
branch
from
96ecbf1 to
b8f4537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few code improvements are indicated by clang-tidy and compiler warnings.