Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Translating Mesh3 C++ example into Python #66

Merged
merged 3 commits into from
May 23, 2022
Merged

ENH: Translating Mesh3 C++ example into Python #66

merged 3 commits into from
May 23, 2022

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Aug 28, 2018

blocker: identifiers beginning with a digit are not supported

  File "./Code.py", line 29
    CellTraits = itk.itkCellTraitsInfo.2FFULLULLULLPF2MCULLPF2
                                       ^
SyntaxError: invalid syntax

@thewtex
Copy link
Member

thewtex commented Aug 29, 2018 

  File "./Code.py", line 29
    CellTraits = itk.itkCellTraitsInfo.2FFULLULLULLPF2MCULLPF2
                                       ^
SyntaxError: invalid syntax

@fbudin69500 I seem to recall we discussed this issue in the past. Did we end up changing the name mangling so it did not start with a number?

@thewtex thewtex mentioned this pull request Jan 13, 2019
Merged
@thewtex
Copy link
Member

thewtex commented Feb 23, 2021

@dzenanz could this please be rebased on master and updated to use itk.meshread, etc?

@dzenanz dzenanz mentioned this pull request Mar 15, 2021
Closed
@thewtex
Copy link
Member

thewtex commented May 18, 2021

Rebased and updated. We need to add LineCell wrapping.

@dzenanz @thewtex
WIP: translating Mesh3 C++ example into Python
ec82410 
blockers: LineCell is not wrapped, identifiers beginning with a digit

Change-Id: Ie0daba4975cf90148345eac9ccffa2898f0e1f4b
@PranjalSahu
Copy link
Collaborator

@dzenanz can you please allow edits by maintainers. I can push my changes to your branch then.

@dzenanz
Copy link
Member Author

dzenanz commented May 23, 2022

allow edits by maintainers

I already do. I now added you as a maintainer to the repository.

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module language:C++ Changes to C++ examples language:Python Changes to Python examples type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels May 23, 2022
@dzenanz
Copy link
Member Author

dzenanz commented May 23, 2022

@PranjalSahu please rename the PR once it is ready. As I cannot review my own PR, at least you should review it.

@dzenanz dzenanz requested a review from tbirdso May 23, 2022 16:26
@PranjalSahu PranjalSahu changed the title WIP: translating Mesh3 C++ example into Python ENH: Translating Mesh3 C++ example into Python May 23, 2022
@dzenanz
Copy link
Member Author

dzenanz commented May 23, 2022

LGTM

tbirdso
tbirdso suggested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Similar to @dzenanz 's review, a couple of requests for style updates.

src/Core/Mesh/AccessDataInCells/Code.cxx Outdated Show resolved Hide resolved
src/Core/Mesh/AccessDataInCells/Code.cxx Outdated Show resolved Hide resolved
@PranjalSahu
Copy link
Collaborator

ok I will do the changes.

@github-actions github-actions bot added the type:Enhancement Improvement of existing methods or implementation label May 23, 2022
tbirdso
tbirdso approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PranjalSahu !

@tbirdso
Copy link
Contributor

tbirdso commented May 23, 2022

Please run clang-format on Code.cxx to resolve the linting failure

thewtex
thewtex approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇 🍾 🎆

@PranjalSahu PranjalSahu merged commit b23bd74 into InsightSoftwareConsortium:master May 23, 2022
@dzenanz dzenanz deleted the mesh3 branch May 24, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@thewtex thewtex thewtex approved these changes

@fbudin69500 fbudin69500 Awaiting requested review from fbudin69500

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module language:C++ Changes to C++ examples language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzenanz @thewtex @PranjalSahu @tbirdso