-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ARM builds and notebook test #70
ENH: Add ARM builds and notebook test #70
Conversation
Updates to latest reusable workflow commit to include ARM builds and improved Linux job scheduling. Also enables notebook tests.
@thewtex Glancing back through EDIT: Initial test run here uses |
ipywidget support in 1.0 is in progress (tracked in InsightSoftwareConsortium/itkwidgets#556).
This should have been addressed with 0.32.5 re: InsightSoftwareConsortium/itkwidgets#588 Care may need to be taken in how jupyter / itkwidgets is installed to ensure traitlets is < 5.7? |
It does look like traitlets 5.8 is installed, will update
|
Resolves issues identified in automated Python notebook testing: - The number of components to split with `SplitComponentsImageFilter` is now fixed at 3 for RGB and 4 for RGBA images rather than being defined by the image dimension. Under previous behavior only the first two RG components could be extracted for a 2D image. - Updated to use pythonic `itk.image_duplicator` - Downgrades `traitlets` for compatibility with `itkwidgets==0.32.5` Also updates `.gitignore` to ignore example artifacts.
Downgrading to Rebased and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on a glance.
Applies recent changes in ITKRemoteModuleBuildTestPackageAction to add Jupyter Notebook tests to CI.
Includes fix for
itk.SplitComponentsImageFilter
wrapping where the number of components to split for RGB/RGBA images was tied to the image dimension rather than the implied pixel dimension.