-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Bump reusable workflow for wheel validation #71
ENH: Bump reusable workflow for wheel validation #71
Conversation
Maybe this CMake warning is the culprit for breakage?
|
Yes, though I am curious about where the issue is introduced. I am re-running checks in |
Was CMake version bumped? I think this warning starts with CMake 3.24. |
You're right, the CMake version was bumped as part of warning fixes. InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@6e81bbd It seems like this fix should be handled in ITK proper since it involves setting a CMake policy? EDIT: Already logged in InsightSoftwareConsortium/ITK#3846 |
Re-running checks in InsightSoftwareConsortium/ITK#3846 documents the issue but also includes references to where fixes where already introduced to ITK. Unclear where the error is suddenly coming from here. |
ITKSplitComponents might need to set the policy, like this: |
Could this be added to |
Error appears to have cleared on re-run for no reason? 😕 |
Requiring a newer version of CMake will automatically set all previously introduced policies to NEW. Setting things in |
Yes, that would be the goal. If that's not desirable then I'm fine with setting the policy here as needed. However, it seems like the issue may not be present in the latest run. Will do a third run to check again. EDIT: MacOS builds have failed with warnings on the third, fourth, and fifth runs. No clue why the second passed. Will add a line to set the policy in |
166db98
to
f96429d
Compare
Includes checks for wheel existence and naming scheme after wheel build routines.
Resolves CMake warning regarding CMP135 policy introduced in CMake 3.24
f96429d
to
981b099
Compare
Includes checks for wheel existence and naming scheme after wheel build routines.