Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard C offsetof() for struct offset calculations #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanm
Copy link
Collaborator

@seanm seanm commented Jan 17, 2025

  • The NT_OFF() macro was basically doing what offsetof() does, it probably predates it.
  • Removed SHOW_STRUCT_OFFSET macro because nothing uses it, not even in comments.
  • Changed NT_SFILL macro to use offsetof(). This required a change to its first parameter to provide the stuct name, instead of an actual variable point to a struct. Since this macro is in a header, maybe someone is using it as public API so also renamed it to NT_FILL(). Updated all call sites. Since the new formulation only needs the struct name, also removed the instantation of a struct on the stack.

- The NT_OFF() macro was basically doing what offsetof() does, it probably predates it.
- Removed SHOW_STRUCT_OFFSET macro because nothing uses it, not even in comments.
- Changed NT_SFILL macro to use offsetof(). This required a change to its first parameter to provide the stuct name, instead of an actual variable point to a struct. Since this macro is in a header, maybe someone is using it as public API so also renamed it to NT_FILL(). Updated all call sites. Since the new formulation only needs the struct name, also removed the instantation of a struct on the stack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant