Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add upload symbol files command #1137

Merged
merged 10 commits into from
Feb 19, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 15, 2024

Description of the change

Create a script to upload .so files using our API to BE
node nodemodules/instabug-reactnative/bin/index.js upload-so-files
--arch 'x86 | 'x86_64' | 'arm64-v8a' | 'armeabi-v7a'
--file 'path of ZIP file contains .so files'
--token 'App token'
--name 'Application version like 1.0'
--api_key 'API key you can get from Help'

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA-ID :MOB-13795

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 15, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title feat:add-upload-so-files-command feat:add upload symbol files command Feb 15, 2024
@mnoseir
Copy link

mnoseir commented Feb 15, 2024

Coverage Report

Label Coverage Status
JavaScript 96.2%
Android 47.2%
iOS 41.3%

Generated by 🚫 dangerJS against f7cc8b2

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort implementing this script 💪 Please check the suggestions 🙏 .

cli/UploadSoFiles.ts Show resolved Hide resolved
cli/UploadSoFiles.ts Show resolved Hide resolved
cli/UploadSoFiles.ts Show resolved Hide resolved
cli/UploadSoFiles.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedAlaaInstabug Fantastic effort, the script is quite thorough and readable. Keep up the excellent work !!

LGTM 🎉 🚀
LGTM-Shaun-the-sheep

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 35b64b5 into dev Feb 19, 2024
0 of 2 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/add-upload-so-files-command branch February 19, 2024 12:29
ahmedAlaaInstabug added a commit that referenced this pull request Feb 20, 2024
* chore(android): bump sdk to v12.7.1 (#1134)

* feat:add-upload-so-files-command

* feat:add-upload-so-files-command

* fix: add file path check

* feat: add file validations

* feat: add file validations

* chore: format UploadSoFiles.ts

* chore: add changes in changeLog

---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
* chore(android): bump sdk to v12.7.1 (#1134)

* feat:add-upload-so-files-command

* feat:add-upload-so-files-command

* fix: add file path check

* feat: add file validations

* feat: add file validations

* chore: format UploadSoFiles.ts

* chore: add changes in changeLog

---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
* chore(android): bump sdk to v12.7.1 (#1134)

* feat:add-upload-so-files-command

* feat:add-upload-so-files-command

* fix: add file path check

* feat: add file validations

* feat: add file validations

* chore: format UploadSoFiles.ts

* chore: add changes in changeLog

---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants