Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBGBUGCHAT-10593] support certificate content type #6

Open
wants to merge 1 commit into
base: url-filter
Choose a base branch
from

Conversation

smohamedinstabug
Copy link

@smohamedinstabug smohamedinstabug commented Dec 6, 2020

Problem:

file command considers the pem files as “text/plain” and mimemagic can't detect the pem files content type

Solution:

Try to open a file with OpenSSL::X509::Certificate. so If the file opened successfully, it will be a pem file.

Notes:

TODO: anything that reviewers should know before reviewing?

QC Notes:

TODO: What parts/flows of the app are affected by this change?

Release steps:

TODO: steps needed for the release. If no special handling needed, please write 'Normal Release'

Security:

TODO: Are the changes exposed publicly or internally?

TODO: Do all new endpoints impose proper access to authorized users only?

Network:

TODO: Link to Ops PR if any. Type N/A if none.

TODO: List new internal/external services communications that were introduced in this PR. Type N/A if none.

Author checklist:

  • Backward compatibility checked
  • Release steps added
  • Unit tests added (if code logic is touched)
  • JIRA ticket moved to Reviewing
  • Rebased to latest master
  • Commits are clean

Reviewer checklist:

  • Backward compatibility checked
  • Code quality is acceptable
  • Specs logic coverage
  • Commits are clean

@smohamedinstabug smohamedinstabug changed the title support certificate content type [IBGBUGCHAT-10593] support certificate content type Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant