Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NSUInteger to NSInteger in public API #200

Closed
rnystrom opened this issue Nov 15, 2016 · 1 comment
Closed

Change NSUInteger to NSInteger in public API #200

rnystrom opened this issue Nov 15, 2016 · 1 comment
Labels
enhancement starter-task
Milestone
2.0.0

Comments

@rnystrom
Copy link
Contributor

This makes interop w/ Swift tricky. Let's audit and swap all NSUInteger to NSInteger in the public headers.

e.g. https://github.com/Instagram/IGListKit/blob/master/Source/IGListAdapter.h#L160
@rnystrom rnystrom added this to the 2.0.0 milestone Nov 15, 2016
@surayashivji surayashivji mentioned this issue Nov 16, 2016
Closed
3 tasks
@zhubofei zhubofei mentioned this issue Nov 16, 2016
Closed
facebook-github-bot pushed a commit that referenced this issue Nov 16, 2016
@surayashivji
Swap NSUInteger to NSInteger Public API
e2fbb68 
Summary:
Swapped NSUInteger to NSInteger in public headers. Fixed a test in IGListSectionMapTests.m to pass with NSInteger. For issue #200!

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes #205

Differential Revision: D4191521

Pulled By: rnystrom

fbshipit-source-id: 3f15c5ee3f8ed2d382de2602912a2e998bfbcbba
@jessesquires
Copy link
Contributor

fixed in e2fbb68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement starter-task
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@rnystrom @jessesquires