Refine dequeueReusableCellOfClass methods for Swift #1388

koenpunt · 2019-11-18T09:40:28Z

Changes in this pull request

Initial suggested implementation for #1387.

Checklist

All tests pass. Demo project builds and runs.
I added tests, an experiment, or detailed why my change isn't tested.
I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
I have reviewed the contributing guide

Source/IGListKit/IGListCollectionContext+Refinements.swift

koenpunt · 2019-11-18T22:02:56Z

Okay, the build is now failing because of the Xcode build settings.
I can submit another PR to update the projects to make them pass again, or I can do that in this PR. Preference?

iperry90 · 2019-11-18T22:32:40Z

Could you update them in this PR so that the build passes? Thanks!

koenpunt · 2019-11-19T14:08:34Z

Could you update them in this PR so that the build passes? Thanks!

I believe I now made the minimal changes required to make the tests pass.

But running the tvOS tests from Xcode doesn't work without removing certain tests files from the tvOS test target. This doesn't show on CI because the tvOS tests are not run there.

Speaking of CI, in terms of speed I think it would be better to move to CircleCI or GitHub Actions; their macOS runners spin up instantly, where Travis can take over 30 minutes.

Would you accept a PR that configures CI for a different provider?

iglistkit-bot · 2019-11-19T14:49:52Z

	3 Warnings
⚠️	Big PR
⚠️	All pull requests should have a milestone attached, unless marked #trivial.
⚠️	Adding or removing library source files requires updating the examples. Please run `./scripts/pod_setup.sh` from the root directory and commit the changes.

Generated by 🚫 Danger

Ziewvater · 2019-11-20T00:13:00Z

@koenpunt I think we'd wanna discuss a change in CI a bit internally before making that decision, but if you'd like to open up an issue and make the case for it there, that'd be great! It'd definitely be helpful for me since I don't have much experience with CIs outside of our own internal one.

lorixx · 2019-11-21T06:13:16Z

Hi Koen, thanks for working and fixing the test here! We are working on making a 4.0 release this week, will ping you on this PR once the new release is out, thx!

lorixx · 2019-11-22T18:26:10Z

Hi @koenpunt , we released 4.0 yesterday, can you resolve the conflicts on your PR and re-submit? thanks :)

lorixx

Thanks for simplifying the APIs for Swift here! It's ready to merge in now, please rebase onto master/stable and test again, thanks!

CHANGELOG.md

lorixx · 2019-11-23T09:01:59Z

Examples/Examples-iOS/IGListKitExamples.xcodeproj/project.pbxproj

@@ -1015,7 +1015,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 9.3;
+				IPHONEOS_DEPLOYMENT_TARGET = 9.0;


lorixx · 2019-11-23T09:02:50Z

Examples/Examples-iOS/IGListKitExamples/SectionControllers/EmbeddedSectionController.swift

@@ -30,7 +30,7 @@ final class EmbeddedSectionController: ListSectionController {
    }

    override func cellForItem(at index: Int) -> UICollectionViewCell {
-        guard let cell = collectionContext?.dequeueReusableCell(of: CenterLabelCell.self, for: self, at: index) as? CenterLabelCell else {
+        guard let cell = collectionContext?.dequeueReusableCell(of: CenterLabelCell.self, for: self, at: index) else {


lorixx · 2019-11-23T09:03:45Z

Source/IGListKit/IGListCollectionContext+Refinements.swift

+        of cellClass: T.Type, withReuseIdentifier reuseIdentifier: String,
+        for sectionController: ListSectionController, at index: Int) -> T {


My nit feedback is to use new line for each individual arguments.

Do you feel strongly about this? I grouped them, since the the cell class and reuse identifier are related, and so are the section controller and the index.

I dont feel too strongly abt it, which I said it's just a 'nit feedback', up to u :))

lorixx · 2019-11-23T09:04:06Z

Source/IGListKit/IGListCollectionContext+Refinements.swift

+        of cellClass: T.Type,
+        for sectionController: ListSectionController, at index: Int) -> T {


facebook-github-bot

@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

natestedman · 2019-12-12T17:33:37Z

Hey @koenpunt, thanks for this new API! Unfortunately we can't take Swift code in the main IGListKit target yet, as it would mandate shipping the Swift libraries (and Swift code in general) in apps that are not using Swift yet, but are using IGListKit.

So, we're going to adjust these new APIs around a bit internally to split out them out into a separate library (probably named IGListKitSwift?) that will be available as a separate Cocoapod/Carthage dependency.

We're going to plan to ship this change to Github next week.

koenpunt · 2019-12-17T10:10:28Z

So, we're going to adjust these new APIs around a bit internally to split out them out into a separate library (probably named IGListKitSwift?) that will be available as a separate Cocoapod/Carthage dependency.

My initial approach was to make it a separate library, but I had a hard time (and didn't spend too much time on it) to make it work with injecting an apinotes file into the framework and then repackaging that as a new library (an approach described here: https://pspdfkit.com/blog/2018/first-class-swift-api-for-objective-c-frameworks/#api-notes).

But if there's anything I can do, or if you'd like me to dive into it again, please let me know, I'm happy to help :)

facebook-github-bot · 2019-12-19T16:42:58Z

@natestedman merged this pull request in f1ceedc.

Summary: We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here Differential Revision: D20036436 fbshipit-source-id: 2dbddf0fb029eb165502f1b9d9c0b3be7a964e23

Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here Differential Revision: D20036436 fbshipit-source-id: dc77dfae335420fe310ad39a662753af831a1054

Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: e9344c847c4be837bc43306a3128ffc87246efd5

Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here The solution here is to lint the specs separately in travis, so that for IGListSwiftKit we only lint against ios and tvos. And the other podspecs will still lint against on all platform, including the macos. Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: a2567e439f53593639bff949207af87ff42f6507

Summary: Pull Request resolved: Instagram#1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: Instagram#1388 cc natestedman who might know the context here The solution here is to lint the specs separately in travis, so that for IGListSwiftKit we only lint against ios and tvos. And the other podspecs will still lint against on all platform, including the macos. Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: 67c1578779a20435af0c43428c40a38ad18265b3

Summary: Pull Request resolved: #1428 We kept getting an error as the following: ``` - ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target `App` (macOS 10.11) is not compatible with `IGListSwiftKit (4.1.0)`, which does not support `macOS`.) during validation. ``` Looks like IGListSwiftKit did not support macos, wondering why this is the case here. Potentially this error was introduced in this PR: #1388 cc natestedman who might know the context here The solution here is to lint the specs separately in travis, so that for IGListSwiftKit we only lint against ios and tvos. And the other podspecs will still lint against on all platform, including the macos. Reviewed By: natestedman Differential Revision: D20036436 fbshipit-source-id: 5406cef1825fc4c157fee9ca5856ace81df0508d

facebook-github-bot added the CLA Signed label Nov 18, 2019

koenpunt commented Nov 18, 2019

View reviewed changes

Source/IGListKit/IGListCollectionContext+Refinements.swift Outdated Show resolved Hide resolved

koenpunt force-pushed the swift-refinements branch 3 times, most recently from 6d4e985 to 9f10ece Compare November 18, 2019 17:41

koenpunt marked this pull request as ready for review November 19, 2019 18:20

koenpunt force-pushed the swift-refinements branch from 4a9d71f to fa2c917 Compare November 20, 2019 21:24

koenpunt mentioned this pull request Nov 20, 2019

CI Improvements #1395

Open

koenpunt force-pushed the swift-refinements branch 2 times, most recently from 45a4dd8 to 3b578a0 Compare November 21, 2019 14:33

lorixx approved these changes Nov 23, 2019

View reviewed changes

koenpunt added 3 commits November 24, 2019 18:21

refine dequeueReusableCellOfClass methods for Swift

7730117

update examples to make use of the refined dequeueReusableCell

1fbb4f7

update xcode projects to make tests pass

8150d45

koenpunt force-pushed the swift-refinements branch from 45a4dd8 to 8150d45 Compare November 24, 2019 17:23

update changelog [skip ci]

3ff3a57

koenpunt force-pushed the swift-refinements branch from 54d5393 to 3ff3a57 Compare November 24, 2019 17:36

facebook-github-bot reviewed Nov 25, 2019

View reviewed changes

facebook-github-bot closed this in f1ceedc Dec 19, 2019

facebook-github-bot added the Merged label Dec 19, 2019

lorixx mentioned this pull request Feb 21, 2020

Fix the podlint error #1428

Closed

barakwei mentioned this pull request Aug 23, 2023

IGListKit: fix project warnings. Lightricks/IGListKit#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refine dequeueReusableCellOfClass methods for Swift #1388

Refine dequeueReusableCellOfClass methods for Swift #1388

koenpunt commented Nov 18, 2019 •

edited

Loading

koenpunt commented Nov 18, 2019

iperry90 commented Nov 18, 2019

koenpunt commented Nov 19, 2019

iglistkit-bot commented Nov 19, 2019

Ziewvater commented Nov 20, 2019

lorixx commented Nov 21, 2019

lorixx commented Nov 22, 2019

lorixx left a comment

lorixx Nov 23, 2019

lorixx Nov 23, 2019

lorixx Nov 23, 2019

koenpunt Nov 24, 2019

lorixx Nov 24, 2019

lorixx Nov 23, 2019

facebook-github-bot left a comment

natestedman commented Dec 12, 2019

koenpunt commented Dec 17, 2019

facebook-github-bot commented Dec 19, 2019

		of cellClass: T.Type, withReuseIdentifier reuseIdentifier: String,
		for sectionController: ListSectionController, at index: Int) -> T {

		of cellClass: T.Type,
		for sectionController: ListSectionController, at index: Int) -> T {

Refine dequeueReusableCellOfClass methods for Swift #1388

Refine dequeueReusableCellOfClass methods for Swift #1388

Conversation

koenpunt commented Nov 18, 2019 • edited Loading

Changes in this pull request

Checklist

koenpunt commented Nov 18, 2019

iperry90 commented Nov 18, 2019

koenpunt commented Nov 19, 2019

iglistkit-bot commented Nov 19, 2019

Ziewvater commented Nov 20, 2019

lorixx commented Nov 21, 2019

lorixx commented Nov 22, 2019

lorixx left a comment

Choose a reason for hiding this comment

lorixx Nov 23, 2019

Choose a reason for hiding this comment

lorixx Nov 23, 2019

Choose a reason for hiding this comment

lorixx Nov 23, 2019

Choose a reason for hiding this comment

koenpunt Nov 24, 2019

Choose a reason for hiding this comment

lorixx Nov 24, 2019

Choose a reason for hiding this comment

lorixx Nov 23, 2019

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

natestedman commented Dec 12, 2019

koenpunt commented Dec 17, 2019

facebook-github-bot commented Dec 19, 2019

koenpunt commented Nov 18, 2019 •

edited

Loading