Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deselection from stack collection context offset #295

Closed
wants to merge 2 commits into from

Conversation

rnystrom
Copy link
Contributor

@rnystrom rnystrom commented Dec 6, 2016

Changes in this pull request

Offset should be relative.

Fixes #279

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I have reviewed the contributing guide

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

1 similar comment
@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@rnystrom
Copy link
Contributor Author

rnystrom commented Dec 6, 2016

@jessesquires last PR before 2.0.0. Letting CI ✅ then landing!

@jessesquires jessesquires added this to the 2.0.0 milestone Dec 6, 2016
@rnystrom
Copy link
Contributor Author

rnystrom commented Dec 7, 2016

Looks like the same UI test failed again. Landing.

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jessesquires jessesquires deleted the stack-offset branch December 7, 2016 03:44
@jessesquires jessesquires mentioned this pull request Dec 7, 2016
@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Changes Unknown when pulling 6d9b5c3 on stack-offset into ** on master**.

@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Changes Unknown when pulling 6d9b5c3 on stack-offset into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants