disables prefetchEnabled by default #323
Conversation
| [self updateIGListCollectionViewDefaultValues]; | ||
| } | ||
| return self; | ||
| } |
There was a problem hiding this comment.
ha 😅 we removed initWithCoder: previously so that we don't override storyboard settings.
let's remove, but let's keep your tests (asserts will need to be flipped)
| return self; | ||
| } | ||
|
|
||
| - (void)updateIGListCollectionViewDefaultValues { |
There was a problem hiding this comment.
let's rename: updateWithDefaultValues
|
Actually, it feels bad to override storyboard settings. We probably shouldn't... Maybe we only do it for the prefetch property? cc @rnystrom |
|
1 more thing - @svenbacia, can you also update the CHANGELOG ? 😄 |
|
@svenbacia +1 only changing the I took a look and storyboards do have this as an option. However I think it's still worth disabling since you can't actually use the feature. @jessesquires maybe we should override: -(id<UICollectionViewDataSourcePrefetching>)prefetchDataSource {
return nil;
}Maybe assert that it isn't used? Or maybe we add compiler warnings like we do with other illegal methods?
|
|
@svenbacia updated the pull request - view changes |
|
Awesome! @svenbacia just need to rebase then we can land. |
|
@svenbacia updated the pull request - view changes |
|
Done :) |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes in this pull request
Disables
prefetchEnabledby default onIGListCollectionView(#318).Pull request checklist