Rename "withCollectionView:" param to "collectionView:" #491
Conversation
…apterUpdaterDelegate - Rename `didPerformBatchUpdates` param to be consistent with the rest of the protocol. - Update tests.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
vincent-peng
changed the title
There was a problem hiding this comment.
@vincent-peng awesome! Mind updating the CHANGELOG.md since this is a breaking change?
| @@ -39,7 +39,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| - (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater | |||
| didPerformBatchUpdates:(IGListBatchUpdateData *)updates | |||
| withCollectionView:(UICollectionView *)collectionView; | |||
| collectionView:(UICollectionView *)collectionView; | |||
|
@vincent-peng updated the pull request - view changes |
CHANGELOG.md
Outdated
| - (void)listAdapterUpdater:(IGListAdapterUpdater *)listAdapterUpdater | ||
| didPerformBatchUpdates:(IGListBatchUpdateData *)updates | ||
| collectionView:(UICollectionView *)collectionView; | ||
| ``` |
There was a problem hiding this comment.
nit: We probably don't need the old/new here.
What about just saying
Renamed
IGListAdapterUpdaterDelegatemethod tolistAdapterUpdater:didPerformBatchUpdates:collectionView:
w/ the name + PR
|
@vincent-peng updated the pull request - view changes |
|
@vincent-peng updated the pull request - view changes |
|
@vincent-peng updated the pull request - view changes |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
of the protocol.
Changes in this pull request
Related issue: #466
Pull request checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.