Select an item through IGListCollectionContext #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnystrom
suggested changes
Aug 3, 2017
| animated:(BOOL)animated | ||
| scrollPosition:(UICollectionViewScrollPosition)scrollPosition { | ||
| const NSInteger offsetIndex = [self relativeIndexForSectionController:sectionController fromLocalIndex:index]; | ||
| [self.collectionContext selectItemAtIndex:offsetIndex sectionController:self animated:animated scrollPosition:scrollPosition]; |
There was a problem hiding this comment.
@MarvinNazari can we get a unit test for this too? Once we have that we're good to go!
|
nice! 🎉 |
|
@MarvinNazari updated the pull request - view changes |
|
@MarvinNazari updated the pull request - view changes |
|
@MarvinNazari updated the pull request - view changes |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
We already had a API to deselect an item through
IGListCollectionContextthis is the support for selecting an item.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.