fix: spaces around walrus operator are not required (#368)

Fixes #367
Instagram · Aug 12, 2020 · b4e04ea · b4e04ea
1 parent 771d5e1
commit b4e04ea
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/libcst/_nodes/expression.py b/libcst/_nodes/expression.py
@@ -3680,19 +3680,6 @@ class NamedExpr(BaseExpression):
     #: Whitespace after the walrus operator, but before the value.
     whitespace_after_walrus: BaseParenthesizableWhitespace = SimpleWhitespace.field(" ")
 
-    def _validate(self) -> None:
-        super(NamedExpr, self)._validate()
-        if (
-            self.whitespace_before_walrus.empty
-            and not self.target._safe_to_use_with_word_operator(ExpressionPosition.LEFT)
-        ):
-            raise CSTValidationError("Must have at least one space after target.")
-        if (
-            self.whitespace_after_walrus.empty
-            and not self.value._safe_to_use_with_word_operator(ExpressionPosition.RIGHT)
-        ):
-            raise CSTValidationError("Must have at least one space before value.")
-
     def _visit_and_replace_children(self, visitor: CSTVisitorT) -> "NamedExpr":
         return NamedExpr(
             lpar=visit_sequence(self, "lpar", self.lpar, visitor),

diff --git a/libcst/_nodes/tests/test_namedexpr.py b/libcst/_nodes/tests/test_namedexpr.py
@@ -87,6 +87,20 @@ class NamedExprTest(CSTNodeTest):
                 "parser": _parse_statement_force_38,
                 "expected_position": None,
             },
+            {
+                "node": cst.If(
+                    test=cst.NamedExpr(
+                        target=cst.Name(value="x"),
+                        value=cst.Integer(value="1"),
+                        whitespace_before_walrus=cst.SimpleWhitespace(""),
+                        whitespace_after_walrus=cst.SimpleWhitespace(""),
+                    ),
+                    body=cst.SimpleStatementSuite(body=[cst.Pass()]),
+                ),
+                "code": "if x:=1: pass\n",
+                "parser": _parse_statement_force_38,
+                "expected_position": None,
+            },
         )
     )
     def test_valid(self, **kwargs: Any) -> None: