Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Codecov to 2.1.4 #311

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Upgrade Codecov to 2.1.4 #311

merged 1 commit into from
Jun 10, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Jun 10, 2020

Summary

Codecov reports upload stop working for a while. Upgrade the version to see if the issue can be fixed.
https://codecov.io/gh/Instagram/LibCST/pulls

Test Plan

After CI builds, Codecov commented on PR again.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2020
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ed1a2ad). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #311   +/-   ##
=========================================
  Coverage          ?   93.96%           
=========================================
  Files             ?      222           
  Lines             ?    21412           
  Branches          ?        0           
=========================================
  Hits              ?    20119           
  Misses            ?     1293           
  Partials          ?        0           
Impacted Files Coverage Δ
libcst/codemod/commands/ensure_import_present.py 78.57% <0.00%> (ø)
libcst/_version.py 100.00% <0.00%> (ø)
libcst/codegen/gather.py 96.38% <0.00%> (ø)
libcst/codemod/_context.py 100.00% <0.00%> (ø)
libcst/codemod/_visitor.py 82.85% <0.00%> (ø)
libcst/_parser/parso/utils.py 85.56% <0.00%> (ø)
libcst/metadata/__init__.py 100.00% <0.00%> (ø)
libcst/matchers/tests/test_decorators.py 100.00% <0.00%> (ø)
libcst/_batched_visitor.py 94.54% <0.00%> (ø)
libcst/_parser/types/production.py 100.00% <0.00%> (ø)
... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1a2ad...7b019d9. Read the comment docs.

@jimmylai jimmylai marked this pull request as ready for review June 10, 2020 07:04
@jimmylai
Copy link
Contributor Author

jimmylai commented Jun 10, 2020

@josieesh , after this fix is merged, you can also take look at the coverage report on your #308 to see if some code can be covered by adding more test cases.

@jimmylai jimmylai merged commit dcdb046 into master Jun 10, 2020
@jimmylai jimmylai deleted the jimmylai-patch-5 branch June 23, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants