Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maxsplit value in QualifiedName retrieval #312

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

josieesh
Copy link
Contributor

@josieesh josieesh commented Jun 11, 2020

Summary

When working on another branch, noticed:

import a

foo = a.bar

The qualified name of a.bar would get returned as QualifiedName(name="a.b",...)

Test Plan

  • All tests still passtox
  • Check QualifiedName for a.bar is returned as "a.bar"

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #312 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         223      223           
  Lines       21434    21441    +7     
=======================================
+ Hits        20141    20148    +7     
  Misses       1293     1293           
Impacted Files Coverage Δ
libcst/metadata/scope_provider.py 97.11% <100.00%> (ø)
...cst/metadata/tests/test_qualified_name_provider.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcb5be...44aae10. Read the comment docs.

@josieesh josieesh marked this pull request as ready for review June 11, 2020 14:52
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding.
Can you add a test cast?

@josieesh josieesh merged commit cc7bb9d into Instagram:master Jun 11, 2020
@josieesh josieesh deleted the fix_qualified_name branch June 11, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants