Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow ParenthesizedWhitespace before params in FuncDef #342

Merged
merged 2 commits into from
Jul 15, 2020
Merged

fix: allow ParenthesizedWhitespace before params in FuncDef #342

merged 2 commits into from
Jul 15, 2020

Conversation

sk-
Copy link
Contributor

@sk- sk- commented Jul 12, 2020

Summary

Fixes #303

Test Plan

Unit Tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2020
jimmylai
jimmylai approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent fix!

@jimmylai jimmylai merged commit a9177e2 into Instagram:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylai jimmylai jimmylai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate Types fails on FunctionDef
3 participants
@sk- @jimmylai @facebook-github-bot