[metadata] update return type of ParentNodeProvider to be CSTNode #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Kronuz called out that the return type of
ParentNodeProvider
should NOT be anOptional
.That's true because the
original_node
set as metadata is always aCSTNode
.LibCST/libcst/metadata/parent_node_provider.py
Lines 18 to 21 in c023fa7
Test Plan
Existing tests.