-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TypeOf matcher #384
Conversation
I'll leave this to @jimmylai as I'm not at all familiar with matcher implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This can make the operator node matcher patterns simpler.
The code quality is really good with high test coverage.
Just some comments.
Thanks for the merge @jimmylai! This would definitely help me in the future for writing Fixit rules [when the new version got released and linked to the Fixit] |
@isidentical , you're very welcome. Thank you for your contribution. Look forward to see more cool autofixers from you! |
Summary
Implemented a matcher for matching concrete types (instead of instances);
would be equal to
Test Plan