Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't gather dirs ending .py #994

Merged
merged 1 commit into from
Aug 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libcst/codemod/_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ def gather_files(
ret.extend(
str(p)
for p in Path(fd).rglob("*.py*")
if str(p).endswith("py") or (include_stubs and str(p).endswith("pyi"))
if Path.is_file(p)
and (
str(p).endswith("py") or (include_stubs and str(p).endswith("pyi"))
)
)
return sorted(ret)

Expand Down
3 changes: 3 additions & 0 deletions libcst/tests/test_e2e.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ def test_leaky_codemod(self) -> None:
# File that should not be modified
other = tmp / "other.py"
other.touch()
# Just a dir named "dir.py", should be ignored
adir = tmp / "dir.py"
adir.mkdir()

# Run command
command_instance = PrintToPPrintCommand(CodemodContext())
Expand Down
Loading