-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eslint and related upgrades #60
Conversation
steps: | ||
- checkout | ||
- run: yarn --prod # install only prod dependencies first to trigger postinstall patch-package script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the reason you have to resort to this hack is because of this:
ds300/patch-package#84 (comment)
We should make sure we undo this as we work on 2.x branch.
.eslintrc
Outdated
// "parser": "@babel/eslint-parser", | ||
// "parserOptions": { | ||
// "requireConfigFile": true, // This can be true if you have a Babel configuration file | ||
// "babelOptions": { | ||
// "presets": ["@babel/preset-env", "jest"] // Adapt or add other Babel presets as needed | ||
// } | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be removed?
Summary
We had to upgrade a couple of packages (for this) on the web frontend.
This resulted in some linting issues that are a result of de-sync on the
eslint-plugin-instawork
repo on the eslint versioning mismatches. Theeslint-plugin-instawork
packages have been out of date for a while.Here, we've upgraded a bunch of packages in a way that is compatible for both web and mobile repos.
Notes:
eslint-plugin-flowtype
. See this issue.Screenshots
$ yarn test
oneslint-plugin-instawork
repo$ yarn
oninstawork/ali/microfe/testing-enhancements-v2
branch$ yarn test:lint
onapplicant-app
instawork/component-logic-loc
which we had added for web since the rule is crashing due to some issue in the flow syntax.class-methods-use-this
errors that we can probably turn off for the time being.