feat: eslint and related upgrades #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flochtililoch
approved these changes
May 17, 2024
| steps: | ||
| - checkout | ||
| - run: yarn --prod # install only prod dependencies first to trigger postinstall patch-package script |
There was a problem hiding this comment.
I believe the reason you have to resort to this hack is because of this:
ds300/patch-package#84 (comment)
We should make sure we undo this as we work on 2.x branch.
.eslintrc
Outdated
Comment on lines
8
to
14
| // "parser": "@babel/eslint-parser", | ||
| // "parserOptions": { | ||
| // "requireConfigFile": true, // This can be true if you have a Babel configuration file | ||
| // "babelOptions": { | ||
| // "presets": ["@babel/preset-env", "jest"] // Adapt or add other Babel presets as needed | ||
| // } | ||
| // }, |
There was a problem hiding this comment.
should this be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had to upgrade a couple of packages (for this) on the web frontend.
This resulted in some linting issues that are a result of de-sync on the
eslint-plugin-instaworkrepo on the eslint versioning mismatches. Theeslint-plugin-instaworkpackages have been out of date for a while.Here, we've upgraded a bunch of packages in a way that is compatible for both web and mobile repos.
Notes:
eslint-plugin-flowtype. See this issue.Screenshots
$ yarn testoneslint-plugin-instaworkrepo$ yarnoninstawork/ali/microfe/testing-enhancements-v2branch$ yarn test:lintonapplicant-appinstawork/component-logic-locwhich we had added for web since the rule is crashing due to some issue in the flow syntax.class-methods-use-thiserrors that we can probably turn off for the time being.