Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce two new actions: include, include-inner #271

Conversation

terryatgithub
Copy link
Contributor

This PR is to implement the requirement of #270 .
Please check it for detailed info.

if any questions pls let me know.
thank you very much.

@terryatgithub
Copy link
Contributor Author

terryatgithub commented May 13, 2021

update:
we've implemented the complicated cascader menu with the new actions include and include-inner. and can not think of other ways to achieve that effect.
so please help to evaluate, thank you very much.

@adamstep
Copy link
Contributor

adamstep commented May 17, 2021

Hi @terryatgithub . Thanks for the PR implementing these additions. I am not sure if we want to add them to the core Hyperview, I need to take more time to understand whether this is a useful action for general use.

In the meantime, is it possible to add include and include-inner to your app as a custom behavior? I think it should be possible to do it, and you won't be blocked on updates to the core HV library.

@terryatgithub
Copy link
Contributor Author

ok, Adam, thanks for reply. I can understand it. and i will try the method of custom-behavior.
and maybe later I will also create a demo implemented by include and include-inner for your reference.
thanks so much.

@terryatgithub
Copy link
Contributor Author

Because of this wonderful realization in #309 by Adam, this PR is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants