-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm that SetGlobalStartEndYears() works as expected #120
Conversation
Will fix #24 |
With this code we should probably update our standard examples to include a call to SetGlobalStartEndYears():
I've confirmed that the start/end years are carried through to nice plots like this (100 population growth trajectories, with 95% CI around the mean): |
We should update regression tests to use https://github.com/InstituteforDiseaseModeling/Ethiopia-HEP-Capacity-Analysis/blob/charles/issue24/tests/testthat/test_lean_scenario.R to use ehep::SetGlobalStartEndYears with default years, @celiot-IDM do you want me to update this or you can add it? |
@MeWu-IDM : I'm happy for you to make that change! Thanks for calling it out. |
Updated the regression tests and it is passing with default values. This looks good to me |
Addendum to #120: add start/end years to globalconfig.json
Some code tidying, and some unit test confirmation that SetGlobalStartEndYears() works correctly.