Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to deflater native code #88

Merged
merged 1 commit into from
Feb 7, 2018
Merged

update to deflater native code #88

merged 1 commit into from
Feb 7, 2018

Conversation

pnvaidya
Copy link
Contributor

@pnvaidya pnvaidya commented Feb 7, 2018

extra lines of code need to be removed.

@gspowley
Copy link
Contributor

gspowley commented Feb 7, 2018

Please add a description of why this change is needed.

@pnvaidya
Copy link
Contributor Author

pnvaidya commented Feb 7, 2018

Noticed extra lines during code inspection and they could cause potential memory leak ..

gspowley
gspowley approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@gspowley gspowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add memory leak checking to the expanded test plan.

@pnvaidya pnvaidya merged commit 964ccf0 into master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspowley gspowley gspowley approved these changes

@erniebrau erniebrau Awaiting requested review from erniebrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnvaidya @gspowley