More MacOS fixes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to make googletest build. The particular standard was chosen to be old enough that most systems will have no problem - but it may be possible to go back further. Signed-off-by: Alastair Reid <alastair.d.reid@gmail.com>
This resolves a warning about cmake versions. I chose not to update to 1.15.x because those seem to need recent C++ features and we don't want or need to be on the bleeding edge here. Signed-off-by: Alastair Reid <alastair.d.reid@gmail.com>
Signed-off-by: Alastair Reid <alastair.d.reid@gmail.com>
Signed-off-by: Alastair Reid <alastair.d.reid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix more of the issues using ASLi on MacOS
This does not fix all the issues yet
These affect our ability to run tests