Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPEX embedders performance #52

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix IPEX embedders performance #52

merged 2 commits into from
Jul 8, 2024

Conversation

peteriz
Copy link
Contributor

@peteriz peteriz commented Jul 8, 2024

  • Fixed performance issue to IPEX Embedders by adding support for padding and controlling the maximum sequence length per batch.
  • Update the example notebook highlighting the configuration needed for maximizing performance.

@peteriz peteriz requested a review from danielfleischer July 8, 2024 07:44
danielfleischer
danielfleischer approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@danielfleischer danielfleischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peteriz peteriz merged commit dc96dad into main Jul 8, 2024
@peteriz peteriz deleted the fix-ipex-embedders branch July 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfleischer danielfleischer danielfleischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peteriz @danielfleischer