-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax dependencies, add Streaming Callback #71
Conversation
Please see if there's still an issue, after updating protobuf. |
@danielfleischer Solved the Protobuf issue, but issues with Pillow are still there:
|
@danielfleischer last commit added something else I need: passing the streaming callback to the parent. With that commit, this works:
And this is the output to a "Hello" prompt:
The intention here is to get "avg token generation per second" metric and similar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, waiting on feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, merging.
- Relax dependencies and bump version. - Add streaming callback support.
Hi, so I am trying to make a RAG app with fastRAG.
But the dependency definition of fastRAG is causing conflicts with other dependencies.
For example, did
pip install
with thisrequirement.txt
fails:It's usually about
Pillow
andprotobuf
.So, forked the lib, relaxed the dependencies, rebuilt it, and installed it in my project.
It is still working, but I only tried the OpenVINOGenerator feature.
So, proposing this change to allow better compatibility with other libs!