Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rambo workload's numba-dpex implementation with dpnp vector operations #201

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Rambo workload's numba-dpex implementation with dpnp vector operations #201

merged 1 commit into from
Apr 28, 2023

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Apr 6, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?

Adds numba_dpex_n implementation of Rambo workload. It fails validation. Issue has been raised here Failed validation fixed in numba-dpex.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga self-assigned this Apr 6, 2023
@adarshyoga adarshyoga force-pushed the rambo_numpy_version branch from fd55bb3 to b975431 Compare April 12, 2023 21:58
@adarshyoga adarshyoga requested a review from diptorupd April 20, 2023 04:24
@adarshyoga adarshyoga force-pushed the rambo_numpy_version branch from b975431 to 8ec99a4 Compare April 20, 2023 04:24
@adarshyoga adarshyoga force-pushed the rambo_numpy_version branch 2 times, most recently from 5d13dd5 to c9e0d43 Compare April 28, 2023 14:41
@adarshyoga adarshyoga force-pushed the rambo_numpy_version branch from c9e0d43 to 6a4e02d Compare April 28, 2023 17:59
@adarshyoga adarshyoga enabled auto-merge April 28, 2023 19:24
@diptorupd
Copy link

Works now that numba-dpex has been fixed. Good to merge.

diptorupd
diptorupd approved these changes Apr 28, 2023
View reviewed changes
Copy link

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adarshyoga adarshyoga merged commit e4b0da4 into main Apr 28, 2023
@adarshyoga adarshyoga deleted the rambo_numpy_version branch April 28, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@adarshyoga adarshyoga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarshyoga @diptorupd