-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use global config #218
Merged
Merged
Use global config #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
4 times, most recently
from
April 17, 2023 21:11
ccb061f
to
2521de0
Compare
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
from
April 17, 2023 22:28
2521de0
to
bc310f0
Compare
diptorupd
reviewed
Apr 17, 2023
diptorupd
reviewed
Apr 17, 2023
diptorupd
reviewed
Apr 18, 2023
@ZzEeKkAa we need a better name for |
diptorupd
reviewed
Apr 18, 2023
diptorupd
reviewed
Apr 18, 2023
diptorupd
reviewed
Apr 18, 2023
@ZzEeKkAa Overall good progress. Few general comments:
|
diptorupd
reviewed
Apr 18, 2023
diptorupd
reviewed
Apr 18, 2023
diptorupd
reviewed
Apr 18, 2023
I would go with |
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
3 times, most recently
from
April 18, 2023 15:29
415de0c
to
75b34f6
Compare
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
3 times, most recently
from
April 18, 2023 16:58
4295c4d
to
f7827d2
Compare
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
from
April 18, 2023 17:03
f7827d2
to
a99f014
Compare
ZzEeKkAa
force-pushed
the
feature/use_global_config
branch
from
April 18, 2023 17:21
a99f014
to
4d89433
Compare
diptorupd
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use global config and remove json reads from the code. After these changes applied there should be minimal changes to add support for npbench.