Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit #1558

diptorupd · 2024-02-22T06:20:33Z

Have you provided a meaningful PR description?

The libsyclinterface library provides a minimal C API interface to submit kernels to a sycl::queue and use the sycl::handler classes set_arg to set the arguments with which to launch a kernel.

The PR adds a way to create a local_accessor object from a set of required metadata: rank, dtype, shape, and then add the local_accessor as a kernel argument. To enable the changes, the DPCTLKernelArgType enum was expanded and necessary changes made to the queue interface.

The changes are still a work in progress and need test cases. The PR is opened to get early feedback and evaluate the feasibility of the approach.

Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2024-02-22T06:51:32Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

coveralls · 2024-02-22T07:00:08Z

coverage: 87.824% (+0.08%) from 87.743%
when pulling 0da6390 on feature/local_accessor_kernel_arg
into 13f4443 on master.

github-actions · 2024-02-22T07:15:33Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_18 ran successfully.
Passed: 907
Failed: 0
Skipped: 88

libsyclinterface/source/dpctl_sycl_queue_interface.cpp

oleksandr-pavlyk

Looks good to me, modulo a nit comment. Thank you @diptorupd

libsyclinterface/source/dpctl_sycl_queue_interface.cpp

github-actions · 2024-02-29T01:32:46Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_38 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

github-actions · 2024-03-02T00:13:52Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_49 ran successfully.
Passed: 904
Failed: 2
Skipped: 94

github-actions · 2024-03-06T02:59:09Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_63 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-08T05:46:02Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_70 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

github-actions · 2024-03-08T05:51:21Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_70 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

- Adds support in libsyclinterface:: dpctl_sycl_queue_interface for sycl::local_accessor as kernel arguments. - Refactoring to get rid of compiler warnings.

github-actions · 2024-03-08T20:26:47Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_75 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

libsyclinterface/tests/test_sycl_queue_submit_local_accessor_arg.cpp

…ocal-accessor-kernel-arg-type Add local_accessor kernel_arg_type

github-actions · 2024-03-09T20:36:41Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_78 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

Test submit for 1D range, 2D range, and 3D range, and also specify dependent events.

The llvm-cov-report outputs the coverage summary, while llvm-cov-show displays per-line coverage statistics to identify missed lines.

Let LLVM_TOOLS_HOME and PATH to make llvm-cov, and llvm-profdata discoverable by cmake.

…face Improve coverage sycl interface

github-actions · 2024-03-11T18:04:46Z

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_88 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

oleksandr-pavlyk

Looks good to me. Thank you @diptorupd !

diptorupd marked this pull request as draft February 22, 2024 06:20

diptorupd requested a review from oleksandr-pavlyk February 22, 2024 06:20

oleksandr-pavlyk reviewed Feb 22, 2024

View reviewed changes

libsyclinterface/source/dpctl_sycl_queue_interface.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk previously approved these changes Feb 22, 2024

View reviewed changes

diptorupd dismissed oleksandr-pavlyk’s stale review via 9e0754f February 29, 2024 00:43

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from dca1db1 to 9e0754f Compare February 29, 2024 00:43

oleksandr-pavlyk reviewed Feb 29, 2024

View reviewed changes

libsyclinterface/source/dpctl_sycl_queue_interface.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Feb 29, 2024

View reviewed changes

libsyclinterface/source/dpctl_sycl_queue_interface.cpp Outdated Show resolved Hide resolved

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from 9e0754f to 1589677 Compare March 1, 2024 23:27

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from 1589677 to e6f4f55 Compare March 6, 2024 02:13

diptorupd force-pushed the feature/local_accessor_kernel_arg branch 2 times, most recently from 22abbee to 4023e87 Compare March 7, 2024 17:07

diptorupd marked this pull request as ready for review March 8, 2024 05:00

diptorupd requested review from oleksandr-pavlyk and ZzEeKkAa March 8, 2024 05:00

diptorupd changed the title ~~WIP: Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit~~ Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit Mar 8, 2024

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from 0b9caa6 to 41e5abb Compare March 8, 2024 05:06

diptorupd mentioned this pull request Mar 8, 2024

A sycl::local_accessor-like API for numba-dpex kernel IntelPython/numba-dpex#1331

Merged

13 tasks

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from 41e5abb to 37d6de8 Compare March 8, 2024 17:04

Diptorup Deb added 2 commits March 8, 2024 13:41

Support local_accessor kernel arguments.

72be466

- Adds support in libsyclinterface:: dpctl_sycl_queue_interface for sycl::local_accessor as kernel arguments. - Refactoring to get rid of compiler warnings.

Add unit tests for local accessor kernel arg.

f288a2a

diptorupd force-pushed the feature/local_accessor_kernel_arg branch from 37d6de8 to f288a2a Compare March 8, 2024 19:41

Remove leftover class from enum_types.__all__

4736de1

Add local_accessor kernel_arg_type

a3d87a5

oleksandr-pavlyk reviewed Mar 8, 2024

View reviewed changes

libsyclinterface/tests/test_sycl_queue_submit_local_accessor_arg.cpp Outdated Show resolved Hide resolved

Merge pull request #1588 from IntelPython/add-python-counterpart-of-l…

933630a

…ocal-accessor-kernel-arg-type Add local_accessor kernel_arg_type

oleksandr-pavlyk added 10 commits March 9, 2024 19:05

Improve coverage of dpctl_sycl_queue_interface

ae1884b

Test submit for 1D range, 2D range, and 3D range, and also specify dependent events.

host is no longer a valid string selector

78d55c8

Add test for DPCTLQueue_Create for some nullptr args

2457422

Only run test submit if device has aspect fp64

0a12c31

Test Local accessor for ndim=1, 2, 3

2c85fa7

Renamed target llvm-cov to llvm-cov-report, added target llvm-cov-show

05677e6

The llvm-cov-report outputs the coverage summary, while llvm-cov-show displays per-line coverage statistics to identify missed lines.

Update to dbg_build

30661fd

Let LLVM_TOOLS_HOME and PATH to make llvm-cov, and llvm-profdata discoverable by cmake.

Change script to use llvm-cov-report instead of llvm-cov

278fec2

Moved typedef for MDLocalAccessor to dpctl_sycl_queue_interface.hpp

bbb2d54

Merge pull request #1589 from IntelPython/improve-coverage-sycl-inter…

0da6390

…face Improve coverage sycl interface

oleksandr-pavlyk self-requested a review March 11, 2024 19:22

oleksandr-pavlyk approved these changes Mar 11, 2024

View reviewed changes

diptorupd enabled auto-merge March 11, 2024 19:39

diptorupd disabled auto-merge March 11, 2024 19:39

diptorupd merged commit 5f08828 into master Mar 11, 2024
49 checks passed

diptorupd deleted the feature/local_accessor_kernel_arg branch March 11, 2024 19:39

This was referenced Mar 26, 2024

Backport gh-1581 to 0.16.x maintenance branch #1609

Merged

Backport gh 1558 to 0.16.x maintenance branch #1612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit #1558

Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit #1558

diptorupd commented Feb 22, 2024

github-actions bot commented Feb 22, 2024 •

edited

Loading

coveralls commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024

oleksandr-pavlyk left a comment

github-actions bot commented Feb 29, 2024

github-actions bot commented Mar 2, 2024

github-actions bot commented Mar 6, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 11, 2024

oleksandr-pavlyk left a comment

Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit #1558

Allow setting local_accessors as kernel arguments in DPCTLQueue_Submit #1558

Conversation

diptorupd commented Feb 22, 2024

github-actions bot commented Feb 22, 2024 • edited Loading

coveralls commented Feb 22, 2024 • edited Loading

github-actions bot commented Feb 22, 2024

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 29, 2024

github-actions bot commented Mar 2, 2024

github-actions bot commented Mar 6, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 9, 2024

github-actions bot commented Mar 11, 2024

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2024 •

edited

Loading

coveralls commented Feb 22, 2024 •

edited

Loading